[Console] Prevent ArgvInput::getFirstArgument() from returning an option value

[chalasr]

Q	A
Branch?	3.4
Bug fix?	yes
New feature?	no
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	#23343
License	MIT
Doc PR	n/a

Fixes the case where the passed input string contains no command name but one or more global (i.e. application-defined) options accepting values.

[nicolas-grekas]

Do we really need that logic? To me, an approach like #30244 will achieve the same with greater flexibility.

[chalasr]

I think yes, it fixes a real bug. ArrayInput does not suffer from this issue.
#30244 looks like a feature to me as it requires code change for being used, we would need to document it. And the fact it involves to remove an option from the input makes it less flexible to me, IMHO it is not the desired behavior for the 80% use case, keeping in mind that this is not only about --env but any option defined at the application level which are generally meant to be accessed from the final input object at command runtime.

[stof]

how does this handle cases where multiple shortcut gets grouped together ?

[chalasr]

@stof in case the token is a short option (group), this checks that the last char of the token has a value and, if it has one, the next token is skipped. Just added a test + inline comment.

[fabpot]

Thank you @chalasr.