Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VarDumper] fix serializing Stub instances #30274

Merged
merged 1 commit into from Feb 17, 2019

Conversation

nicolas-grekas
Copy link
Member

Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

There are more properties in child classes, and we can skip serializing properties that are set to their default values.

@nicolas-grekas nicolas-grekas merged commit 46d6a4d into symfony:3.4 Feb 17, 2019
nicolas-grekas added a commit that referenced this pull request Feb 17, 2019
This PR was merged into the 3.4 branch.

Discussion
----------

[VarDumper] fix serializing Stub instances

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

There are more properties in child classes, and we can skip serializing properties that are set to their default values.

Commits
-------

46d6a4d [VarDumper] fix serializing Stub instances
@nicolas-grekas nicolas-grekas deleted the vd-ser branch February 19, 2019 14:24
This was referenced Mar 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants