[Console] Fix command testing with missing user inputs #30271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chalasr
force-pushed
the
cli-testing-empty-input-stream
branch
from
7676bf1
to
89a8b0e
Compare
chalasr
force-pushed
the
cli-testing-empty-input-stream
branch
from
89a8b0e
to
11136dd
Compare
OskarStark
reviewed
Feb 16, 2019
src/Symfony/Component/Console/Tests/Helper/QuestionHelperTest.php
Outdated
Show resolved
Hide resolved
chalasr
force-pushed
the
cli-testing-empty-input-stream
branch
from
11136dd
to
85feb82
Compare
nicolas-grekas
approved these changes
Feb 16, 2019
chalasr
force-pushed
the
cli-testing-empty-input-stream
branch
from
85feb82
to
dcdd68f
Compare
OskarStark
approved these changes
Feb 16, 2019
chalasr
force-pushed
the
cli-testing-empty-input-stream
branch
6 times, most recently
from
281116e
to
13c767b
Compare
chalasr
force-pushed
the
cli-testing-empty-input-stream
branch
from
13c767b
to
ac4e9b0
Compare
chalasr
pushed a commit
that referenced
this pull request
Feb 19, 2019
…alasr) This PR was merged into the 3.4 branch. Discussion ---------- [Console] Fix command testing with missing user inputs | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #30138 | License | MIT | Doc PR | n/a Fixes the remaining cases where test execution hangs using `CommandTester`. Commits ------- ac4e9b0 [Console] Fix command testing with missing inputs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the remaining cases where test execution hangs using
CommandTester.