[Debug][ErrorHandler] Preserve next error handler #30264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Symfony/Component/Debug/Tests/Fixtures/ErrorHandlerThatUsesThePreviousOne.php
Outdated
Show resolved
Hide resolved
Co-authored-by: Joe <cuchac@email.cz>
fancyweb
force-pushed
the
preserve-next-error-handler
branch
from
6621e8e
to
a8b3434
Compare
|
Thank you @fancyweb. |
nicolas-grekas
added a commit
that referenced
this pull request
Feb 16, 2019
This PR was merged into the 3.4 branch. Discussion ---------- [Debug][ErrorHandler] Preserve next error handler | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #30140 | License | MIT | Doc PR | - Thank you @cuchac Getting the current error handler in the error handler itself actually works. If you try to see the content of the `$currentErrorHandler` var however, you will always see `null`. That's why I thought it was impossible. Because I did not test from end to end until today. Commits ------- a8b3434 [Debug][ErrorHandler] Preserve next error handler
This was referenced Mar 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you @cuchac
Getting the current error handler in the error handler itself actually works. If you try to see the content of the
$currentErrorHandlervar however, you will always seenull. That's why I thought it was impossible. Because I did not test from end to end until today.