Don't resolve the Deprecation error handler mode until a deprecation is triggered #30247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
approved these changes
Feb 14, 2019
There was a problem hiding this comment.
The issue has been introduced in #20334 btw
Please do not fix the fabbot issues :)
ossinkine
commented
Feb 15, 2019
| @@ -105,8 +105,7 @@ public static function register($mode = 0) | |||
| 'remaining vendor' => array(), | |||
| ); | |||
| $deprecationHandler = function ($type, $msg, $file, $line, $context = array()) use (&$deprecations, $getMode, $UtilPrefix, $inVendors) { | |||
| $mode = $getMode(); | |||
| if ((E_USER_DEPRECATED !== $type && E_DEPRECATED !== $type) || DeprecationErrorHandler::MODE_DISABLED === $mode) { | |||
| if ((E_USER_DEPRECATED !== $type && E_DEPRECATED !== $type) || DeprecationErrorHandler::MODE_DISABLED === ($mode = $getMode())) { | |||
There was a problem hiding this comment.
($mode = $getMode()) or $mode = $getMode() as in original commit?
nicolas-grekas
force-pushed
the
issue-30047
branch
from
bb9abcf
to
1090b8c
Compare
|
Thank you @ossinkine. |
nicolas-grekas
added a commit
that referenced
this pull request
Feb 16, 2019
…eprecation is triggered (ossinkine) This PR was merged into the 3.4 branch. Discussion ---------- Don't resolve the Deprecation error handler mode until a deprecation is triggered | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #30047 | License | MIT <!-- Write a short README entry for your feature/bugfix here (replace this comment block.) This will help people understand your PR and can be used as a start of the Doc PR. Additionally: - Bug fixes must be submitted against the lowest branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against the master branch. --> If an error happens before `.env.test` is loaded the mode is set to 0 and cached so SYMFONY_DEPRECATIONS_HELPER is not read from `.env.test`. Commits ------- 1090b8c Don't resolve the Deprecation error handler mode until a deprecation is triggered
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an error happens before
.env.testis loaded the mode is set to 0 and cached so SYMFONY_DEPRECATIONS_HELPER is not read from.env.test.