Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Form] ignore _method forms in NativeRequestHandler #30076

Merged
merged 1 commit into from Feb 8, 2019
Merged

[Form] ignore _method forms in NativeRequestHandler #30076

merged 1 commit into from Feb 8, 2019

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Feb 4, 2019

Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #19017
License MIT
Doc PR

@xabbuh xabbuh added this to the 3.4 milestone Feb 4, 2019
HeahDude
HeahDude approved these changes Feb 5, 2019
View reviewed changes
Copy link
Contributor

@HeahDude HeahDude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a reasonable fix to keep BC without adding too much complexity.

@nicolas-grekas
Copy link
Member

Thank you @xabbuh.

@nicolas-grekas nicolas-grekas merged commit bc4b091 into symfony:3.4 Feb 8, 2019
nicolas-grekas added a commit that referenced this pull request Feb 8, 2019
@nicolas-grekas
bug #30076 [Form] ignore _method forms in NativeRequestHandler (xabbuh)
68b4825 
This PR was merged into the 3.4 branch.

Discussion
----------

[Form] ignore _method forms in NativeRequestHandler

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #19017
| License       | MIT
| Doc PR        |

Commits
-------

bc4b091 ignore _method forms in NativeRequestHandler
@xabbuh xabbuh deleted the issue-19017 branch February 8, 2019 12:58
This was referenced Mar 3, 2019
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HeahDude HeahDude HeahDude approved these changes

Assignees
No one assigned
Labels
Bug Form Status: Reviewed
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@xabbuh @nicolas-grekas @HeahDude @carsonbot