[Form] do not overwrite the constraint being evaluated #30062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Feb 2, 2019
xabbuh
commented
| Q | A |
|---|---|
| Branch? | 3.4 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #27362 |
| License | MIT |
| Doc PR |
xabbuh
commented
Feb 2, 2019
| { | ||
| if (!$constraint instanceof Form) { |
There was a problem hiding this comment.
The $constraint name is also used below when the constraints configured through the constraints option are iterated, but we do not want to overwrite the reference to the constraint that is validated by this constraints.
vudaltsov
approved these changes
Feb 4, 2019
javiereguiluz
approved these changes
Feb 4, 2019
|
Thank you @xabbuh. |
nicolas-grekas
added a commit
that referenced
this pull request
Feb 7, 2019
…bbuh) This PR was merged into the 3.4 branch. Discussion ---------- [Form] do not overwrite the constraint being evaluated | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #27362 | License | MIT | Doc PR | Commits ------- 345a632 do not overwrite the constraint being evaluated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.