Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in Norwegian translation #30042

Merged
merged 1 commit into from Jan 31, 2019
Merged

Fix typo in Norwegian translation #30042

merged 1 commit into from Jan 31, 2019

Conversation

tarjei
Copy link
Contributor

@tarjei tarjei commented Jan 30, 2019

Q A
Branch? master for features / 3.4 up to 4.2 for bug fixes
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #...
License MIT

Minor translation fix.

javiereguiluz
javiereguiluz approved these changes Jan 30, 2019
View reviewed changes
Copy link
Member

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Google Translate considers both right ... but påloggingsinformasjonen gives 13,900 results on Google and påloggingsinformasjon gives 588,000 results.

@tarjei
Copy link
Contributor Author

tarjei commented Jan 30, 2019

It's a bit like saying "Invalid the credentials." instead of "Invalid credentials." :)

stof
stof approved these changes Jan 30, 2019
View reviewed changes
Copy link
Member

@stof stof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know nothing about Norwegian (as most of the core team) so I will assume this is right.

@chalasr chalasr changed the base branch from master to 3.4 January 31, 2019 10:03
@chalasr
Copy link
Member

chalasr commented Jan 31, 2019

Thank you @tarjei.

@chalasr chalasr merged commit e8cdda3 into symfony:3.4 Jan 31, 2019
chalasr pushed a commit that referenced this pull request Jan 31, 2019
minor #30042 Fix typo in Norwegian translation (tarjei)
38d5528 
This PR was submitted for the master branch but it was merged into the 3.4 branch instead (closes #30042).

Discussion
----------

Fix typo in Norwegian translation

| Q             | A
| ------------- | ---
| Branch?       | master for features / 3.4 up to 4.2 for bug fixes <!-- see below -->
| Bug fix?      | no
| New feature?  |no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #...   <!-- #-prefixed issue number(s), if any -->
| License       | MIT

Minor translation fix.

Commits
-------

e8cdda3 Fix typo in translation
@chalasr chalasr added this to the 3.4 milestone Jan 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiereguiluz javiereguiluz javiereguiluz approved these changes

@stof stof stof approved these changes

@chalasr chalasr chalasr approved these changes

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tarjei @chalasr @javiereguiluz @stof @carsonbot