Use system wide memcached.so #30030
Use system wide memcached.so #30030
Conversation
.travis.yml
Outdated
| @@ -188,30 +188,36 @@ before_install: | |||
| tfold ext.mongodb tpecl mongodb-1.6.0alpha1 mongodb.so $INI | |||
| fi | |||
|
|
|||
| echo extension = memcached.so >> $INI | |||
There was a problem hiding this comment.
should be after the if I suppose, see failures
.travis.yml
Outdated
| echo extension = memcached.so >> $INI | ||
| echo extension = $ext_cache >> $INI | ||
| else | ||
| echo extension = memcached.so >> $INI |
There was a problem hiding this comment.
can't we use always this line outside of the if and remove the one before?
There was a problem hiding this comment.
I don't think so. The first is from cache and the second is the system wide. The cache is not in the ini path ... Let's try to find out
.travis.yml
Outdated
| fi | ||
|
|
||
| echo extension = memcached.so >> $INI |
There was a problem hiding this comment.
ok, got it, should be inside the previous if (but not inside the nested if), isn't it?
There was a problem hiding this comment.
the tests pass but that is not supposed to work. I see that the system wide ext/memcached got bumped to version 3.1.2. See if it works without all the compiling ...
|
@nicolas-grekas this is better |
|
Awesome! Could you move the line back to the |
|
Thank you @tvlooy. |
This PR was merged into the 3.4 branch. Discussion ---------- Use system wide memcached.so | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | WiP | License | MIT requested by #29624 (comment) let's see what travis is going to do with this ... Commits ------- 8d171f4 Use system wide memcached.so
|
Merged in 4.2, let's see the same for amqp.so? |
This PR was merged into the 4.2 branch. Discussion ---------- New extensions were released supporting PHP 7.3 | Q | A | ------------- | --- | Branch? | 4.2 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | see travis | License | MIT Requested in #30030 Commits ------- 31de71d New extensions were released supporting PHP 7.3
requested by #29624 (comment)
let's see what travis is going to do with this ...