Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Form] fix some docblocks and type checks #30028

Merged
merged 1 commit into from Jan 30, 2019
Merged

[Form] fix some docblocks and type checks #30028

merged 1 commit into from Jan 30, 2019

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Jan 29, 2019

Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #30018
License MIT
Doc PR

@xabbuh xabbuh added this to the 3.4 milestone Jan 29, 2019
@xabbuh
Copy link
Member Author

xabbuh commented Jan 30, 2019

I have reverted all the string|int changes. Since the FormConfigBuilder is the only class accepting integers as form names we can probably better deprecate that in Symfony 4.3 and add a type hint in 5.0.

@nicolas-grekas
Copy link
Member

Isn't there some BC break potential here?

@xabbuh
Copy link
Member Author

xabbuh commented Jan 30, 2019

The interface declares that the method must return a string. I wouldn't expect anyone to rely on null being returned. And the basic use case for this method is the block prefix for the form theming where null also doesn't make any sense.

@fabpot
Copy link
Member

fabpot commented Jan 30, 2019

Thank you @xabbuh.

@fabpot fabpot merged commit ec0c371 into symfony:3.4 Jan 30, 2019
fabpot added a commit that referenced this pull request Jan 30, 2019
@fabpot
bug #30028 [Form] fix some docblocks and type checks (xabbuh)
46edcee 
This PR was merged into the 3.4 branch.

Discussion
----------

[Form] fix some docblocks and type checks

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #30018
| License       | MIT
| Doc PR        |

Commits
-------

ec0c371 [Form] fix some docblocks and type checks
@xabbuh xabbuh deleted the issue-30018 branch January 30, 2019 13:06
This was referenced Feb 3, 2019
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@yceruto yceruto yceruto approved these changes

@vudaltsov vudaltsov vudaltsov approved these changes

Assignees
No one assigned
Labels
Bug Form Status: Reviewed
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@xabbuh @nicolas-grekas @fabpot @yceruto @vudaltsov @carsonbot