[VarDumper] dont implement Serializable in Stub #30026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
approved these changes
Jan 29, 2019
xabbuh
reviewed
Jan 30, 2019
| { | ||
| return \serialize([$this->class, $this->position, $this->cut, $this->type, $this->value, $this->handle, $this->refCount, $this->attr]); | ||
| $this->serialized = [$this->class, $this->position, $this->cut, $this->type, $this->value, $this->handle, $this->refCount, $this->attr]; |
There was a problem hiding this comment.
Shouldn't we add the property declaration?
There was a problem hiding this comment.
Nope, that's the trick: this is a purely transient state. Declaring a property would mean extra memory used for each instance for zero benefits.
xabbuh
approved these changes
Jan 30, 2019
chalasr
approved these changes
Jan 30, 2019
nicolas-grekas
added a commit
that referenced
this pull request
Jan 30, 2019
…rekas) This PR was merged into the 3.4 branch. Discussion ---------- [VarDumper] dont implement Serializable in Stub | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #30014 | License | MIT | Doc PR | - `Serializable` is really really broken... Commits ------- 73070d7 [VarDumper] dont implement Serializable in Stub
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Serializableis really really broken...