[Debug][ErrorHandler] Preserve our error handler when a logger sets another one #29869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fancyweb
changed the title
fancyweb
force-pushed
the
always-preserve-error-handler-when-logging
branch
2 times, most recently
from
2c73341
to
6af95d4
Compare
|
Nice finding, LGTM. Could you please have a look at HHVM tests, are they related? (rebasing and checking other PRs on 3.4 might help decide). |
fancyweb
force-pushed
the
always-preserve-error-handler-when-logging
branch
from
6af95d4
to
a40a292
Compare
fancyweb
force-pushed
the
always-preserve-error-handler-when-logging
branch
from
a40a292
to
b979fff
Compare
|
Failures were actually related. Turns out this bug does not exist on the tested HHVM version so we must not readd the error handler. |
nicolas-grekas
approved these changes
Jan 24, 2019
|
Good catch, thanks @fancyweb. |
nicolas-grekas
added a commit
that referenced
this pull request
Jan 25, 2019
…gger sets another one (fancyweb) This PR was merged into the 3.4 branch. Discussion ---------- [Debug][ErrorHandler] Preserve our error handler when a logger sets another one | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - When logging errors handled by the `ErrorHandler::handleError()` method, the logger can temporarily set its own custom error handler. This is for example the case of `Monolog` in the `StreamHandler` class (cf https://github.com/Seldaek/monolog/blob/ebb804e432e8fe0fe96828f30d89c45581d36d07/src/Monolog/Handler/StreamHandler.php#L101). However, when the previous error handler is restored by the logger, it "skips" the real previous handler (the `ErrorHandler::handleError()` one) in the pile and goes back directly to the one before. I guess this is because the `restore_error_handler()` call is technically done in the error handler itself, so it logically restore it to the one before and not to itself. Here is an easy small example that shows the PHP behavior : https://3v4l.org/4OZNZ The only solution I have found to fix it is to set our error handler everytime an error is logged. Here are the things I discovered while trying to find a cleaner fix : - Setting the same error handler in the error handler itself doesn't actually add it to the pile. This is why adding a check is useless. - Checking if the logger modified the error handler is impossible anyway : to get the current error handler, you need to set a new one temporarirly and then revert it. However, when you revert it by calling `restore_error_handler()` you end up having the same problem you are trying to fix... - Also trying to get the current error handler in the error handler itself will return NULL if it is itself. Commits ------- b979fff [Debug][ErrorHandler] Preserve our error handler when a logger set another one
This was referenced Jan 29, 2019
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When logging errors handled by the
ErrorHandler::handleError()method, the logger can temporarily set its own custom error handler. This is for example the case ofMonologin theStreamHandlerclass (cf https://github.com/Seldaek/monolog/blob/ebb804e432e8fe0fe96828f30d89c45581d36d07/src/Monolog/Handler/StreamHandler.php#L101).However, when the previous error handler is restored by the logger, it "skips" the real previous handler (the
ErrorHandler::handleError()one) in the pile and goes back directly to the one before. I guess this is because therestore_error_handler()call is technically done in the error handler itself, so it logically restore it to the one before and not to itself.Here is an easy small example that shows the PHP behavior : https://3v4l.org/4OZNZ
The only solution I have found to fix it is to set our error handler everytime an error is logged.
Here are the things I discovered while trying to find a cleaner fix :
restore_error_handler()you end up having the same problem you are trying to fix...