Revert "bug #29597 [DI] fix reporting bindings on overriden services as unused" #29853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
changed the title
nicolas-grekas
approved these changes
Jan 11, 2019
lyrixx
approved these changes
Jan 11, 2019
dunglas
approved these changes
Jan 11, 2019
fabpot
approved these changes
Jan 13, 2019
|
Thank you @mmarynich. |
fabpot
added a commit
that referenced
this pull request
Jan 13, 2019
…n services as unused" (mmarynich) This PR was merged into the 3.4 branch. Discussion ---------- Revert "bug #29597 [DI] fix reporting bindings on overriden services as unused" This reverts commit 44e9a91, reversing changes made to 91b28ff. | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #29836 | License | MIT | Doc PR | 4.2.2 release changed the way tagged service are injected As asked by @nicolas-grekas #29836 (comment) Commits ------- b3e17d2 Revert "bug #29597 [DI] fix reporting bindings on overriden services as unused (nicolas-grekas)"
xabbuh
added a commit
to xabbuh/symfony
that referenced
this pull request
Jan 14, 2019
In symfony#29853 the bugfix made in symfony#29597 was reverted as it did not work as expected. This fixture file has been modified after the 3.4 branch was merged up to account for the changes made in symfony#2957 and must now be reverted to the former state too.
fabpot
added a commit
that referenced
this pull request
Jan 15, 2019
…abbuh) This PR was merged into the 4.2 branch. Discussion ---------- [DependencyInjection] fix test after revert of bugfix | Q | A | ------------- | --- | Branch? | 4.2 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | In #29853 the bugfix made in #29597 was reverted as it did not work as expected. This fixture file has been modified after the 3.4 branch was merged up to account for the changes made in #2957 and must now be reverted to the former state too. Commits ------- 81f63b1 fix test after revert of bugfix
This was referenced Jan 16, 2019
This was referenced Jan 29, 2019
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 44e9a91, reversing
changes made to 91b28ff.
4.2.2 release changed the way tagged service are injected
As asked by @nicolas-grekas #29836 (comment)