[Console] Fixed #29835: ConfirmationQuestion with default true for answer '0' #29844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ro0NL
approved these changes
Jan 11, 2019
chalasr
requested changes
Jan 11, 2019
src/Symfony/Component/Console/Tests/Question/ConfirmationQuestionTest.php
Outdated
Show resolved
Hide resolved
|
That Appveyor test that's failing looks completely unrelated, and passes locally. Any ideas chaps? |
|
@mrthehud that's unrelated indeed, don't worry about it. |
chalasr
reviewed
Jan 11, 2019
src/Symfony/Component/Console/Tests/Question/ConfirmationQuestionTest.php
Show resolved
Hide resolved
chalasr
approved these changes
Jan 13, 2019
… for answer '0'
nicolas-grekas
force-pushed
the
issue-29835
branch
from
ca6690a
to
a0a7400
Compare
|
Thank you @mrthehud. |
nicolas-grekas
added a commit
that referenced
this pull request
Jan 25, 2019
…true for answer '0' (mrthehud) This PR was squashed before being merged into the 3.4 branch (closes #29844). Discussion ---------- [Console] Fixed #29835: ConfirmationQuestion with default true for answer '0' | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | Almost all, one failure on appveyor? | Fixed tickets | #29835 | License | MIT | Doc PR | n/a <!-- Write a short README entry for your feature/bugfix here (replace this comment block.) This will help people understand your PR and can be used as a start of the Doc PR. Additionally: - Bug fixes must be submitted against the lowest branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against the master branch. --> When using the ConfirmationQuestion class to ask a yes / no question, if the default is true, and the answer regex is '/^y/i', then any value not starting with [yY] is considered false. This must include "0", which previously would return true, producing results such as: ``` $ php bin/console do:stuff $ Do you want to continue? 0 <enter> $ Ok, continuing! ``` Commits ------- a0a7400 [Console] Fixed #29835: ConfirmationQuestion with default true for answer '0'
This was referenced Jan 29, 2019
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the ConfirmationQuestion class to ask a yes / no question,
if the default is true, and the answer regex is '/^y/i', then any
value not starting with [yY] is considered false.
This must include "0", which previously would return true, producing results such as: