[EventDispatcher] Fix unknown priority #29822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The PR conflicts a bit with upstream, during added constructor hints. Let me know what to do, i wasnt necessarily aiming to deprecate not passing this new argument, nor do i want to add a new setter. Also im not sure about applying all short array changes here&now, on 3.4 edit: dropped the constructor arg, but still conflicts :) |
|
could you please rebase? |
|
rebase needed to retrigger the CI bots |
|
@nicolas-grekas done. |
fabpot
approved these changes
Feb 21, 2019
|
Thank you @ro0NL. |
fabpot
added a commit
that referenced
this pull request
Feb 21, 2019
This PR was merged into the 3.4 branch. Discussion ---------- [EventDispatcher] Fix unknown priority | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #... <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> Somehow, after #29411 the profiler actually shows the security firewall `ContextListener`. This listener removes itself at call time, but at this point it's wrapped reference is already in the call stack; to be displayed in the profiler. Because the wrapped listener lazily collects its priority - it asks it from the dispatcher - we get null; the listener was already removed. This causes the profiler to render `-` by default:  This fixes it by always passing the expected priority at call time. Commits ------- 9fb619a [EventDispatcher] Fix unknown priority
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somehow, after #29411 the profiler actually shows the security firewall
ContextListener.This listener removes itself at call time, but at this point it's wrapped reference is already in the call stack; to be displayed in the profiler.
Because the wrapped listener lazily collects its priority - it asks it from the dispatcher - we get null; the listener was already removed.
This causes the profiler to render
-by default:This fixes it by always passing the expected priority at call time.