[HttpFoundation] Check file exists before unlink #29764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ro0NL
reviewed
Jan 4, 2019
| @@ -299,8 +299,7 @@ public function sendContent() | |||
|
|
|||
| fclose($out); | |||
| fclose($file); | |||
|
|
|||
| if ($this->deleteFileAfterSend) { | |||
| if ($this->deleteFileAfterSend && file_exists($this->file->getPathname())) { | |||
There was a problem hiding this comment.
doenst fopen already fail in this case?
There was a problem hiding this comment.
The file can be deleted after fopen() while it is being sent to the user.
There was a problem hiding this comment.
But the file could also be removed between the calls to file_exists() and unlink(). Maybe it would be better to silence the delete operation instead.
There was a problem hiding this comment.
Downloading is a much longer process than file_exists()
There was a problem hiding this comment.
Also, I do not think that @unlink($this->file->getPathname()); would be a good solution here, it will ignore all errors, and not just 'No such file or directory'.
What else needs to be done for this to be merged ?
nicolas-grekas
changed the title
|
Thank you @adam-mospan. |
nicolas-grekas
added a commit
that referenced
this pull request
Jan 25, 2019
…pan) This PR was submitted for the master branch but it was squashed and merged into the 3.4 branch instead (closes #29764). Discussion ---------- [HttpFoundation] Check file exists before unlink Check file exists to prevent ErrorException | Q | A | ------------- | --- | Branch? | 2.6 <!-- see below --> | Bug fix? | yes | New feature? | no <!-- don't forget to update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #... <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> <!-- Write a short README entry for your feature/bugfix here (replace this comment block.) This will help people understand your PR and can be used as a start of the Doc PR. Additionally: - Bug fixes must be submitted against the lowest branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against the master branch. --> Commits ------- 1954187 [HttpFoundation] Check file exists before unlink
This was referenced Jan 29, 2019
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check file exists to prevent ErrorException