Ensure final input of CommandTester works with default #29754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -162,7 +162,7 @@ private static function createStream(array $inputs) | |||
| { | |||
| $stream = fopen('php://memory', 'r+', false); | |||
|
|
|||
| fwrite($stream, implode(PHP_EOL, $inputs)); | |||
| fwrite($stream, implode(PHP_EOL, $inputs).PHP_EOL); | |||
There was a problem hiding this comment.
When an empty array is passed, this writes a PHP_EOL. Legit?
Should the code be rewritten as such?
foreach ($inputs as $line) {
fwrite($stream, $line.PHP_EOL);
}There was a problem hiding this comment.
ping @Simperfit could you review and tell if it's legit to you?
Note that this should target 4.1
chalasr
approved these changes
Jan 3, 2019
There was a problem hiding this comment.
Looks good to me (code owner here). 👍 once @nicolas-grekas's comment addressed
|
I prefer that approach too. Changed :) |
If the final element of `CommandTester::setInputs()` is an empty string (to send the default value), the internal stream the tester uses hits EOF and triggers the `Aborted` exception. This appends an additional EOL to the stream after the `implode` to simulate one final return key, allowing the final input to use the default value when used in the tester's documented style.
|
Rebased on 3.4. Note to mergers: patch needs to be moved to |
|
Good catch, thanks @Firehed. |
chalasr
pushed a commit
that referenced
this pull request
Jan 4, 2019
…rehed) This PR was merged into the 3.4 branch. Discussion ---------- Ensure final input of CommandTester works with default | Q | A | ------------- | --- | Branch? | 4.x | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - If the final element of `CommandTester::setInputs()` is an empty string (to send the default value), the internal stream the tester uses hits EOF and triggers the `Aborted` exception. This appends an additional EOL to the stream after the `implode` to simulate one final return key, allowing the final input to use the default value when used in the tester's documented style. A test has been added to cover the new behavior, which failed before this change. Commits ------- 6b87b67 Ensure final input of CommandTester works with default
|
And thank you for contributing to Symfony! |
This was referenced Jan 6, 2019
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the final element of
CommandTester::setInputs()is an empty string (to send the default value), the internal stream the tester uses hits EOF and triggers theAbortedexception. This appends an additional EOL to the stream after theimplodeto simulate one final return key, allowing the final input to use the default value when used in the tester's documented style.A test has been added to cover the new behavior, which failed before this change.