Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Intl] handle null date and time types #29738

Merged
merged 1 commit into from Jan 3, 2019
Merged

[Intl] handle null date and time types #29738

merged 1 commit into from Jan 3, 2019

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Dec 31, 2018

Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #29705
License MIT
Doc PR

@xabbuh xabbuh added this to the 3.4 milestone Dec 31, 2018
ro0NL
ro0NL reviewed Jan 3, 2019
View reviewed changes
Copy link
Contributor

@ro0NL ro0NL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getDateType + static create() also need a patch

src/Symfony/Component/Intl/DateFormatter/IntlDateFormatter.php Outdated Show resolved Hide resolved
@xabbuh
Copy link
Member Author

xabbuh commented Jan 3, 2019

@ro0NL I fail to see which change is needed for getDateType().

ro0NL
ro0NL approved these changes Jan 3, 2019
View reviewed changes
Copy link
Contributor

@ro0NL ro0NL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

never mind, $dateType cant be null anymore :)

@nicolas-grekas
Copy link
Member

Thank you @xabbuh.

@nicolas-grekas nicolas-grekas merged commit 6ded31a into symfony:3.4 Jan 3, 2019
nicolas-grekas added a commit that referenced this pull request Jan 3, 2019
@nicolas-grekas
bug #29738 [Intl] handle null date and time types (xabbuh)
c573cfb 
This PR was merged into the 3.4 branch.

Discussion
----------

[Intl] handle null date and time types

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #29705
| License       | MIT
| Doc PR        |

Commits
-------

6ded31a [Intl] handle null date and time types
@xabbuh xabbuh deleted the issue-29705 branch January 3, 2019 17:02
@xabbuh xabbuh mentioned this pull request Jan 4, 2019
Merged
This was referenced Jan 6, 2019
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@ro0NL ro0NL ro0NL approved these changes

Assignees
No one assigned
Labels
Bug Intl Status: Reviewed
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@xabbuh @nicolas-grekas @ro0NL @carsonbot