[FrameworkBundle] improve errors in tests missing the BrowserKit component #29704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Dec 27, 2018
xabbuh
commented
| Q | A |
|---|---|
| Branch? | 3.4 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #29696 |
| License | MIT |
| Doc PR |
| try { | ||
| $client = $kernel->getContainer()->get('test.client'); | ||
| } catch (ServiceNotFoundException $e) { | ||
| throw new \LogicException('The BrowserKit component is required to be able to create a client.', $e->getCode(), $e); |
There was a problem hiding this comment.
Could we reword this to be similar to other error messages added recently?
throw new \LogicException('You can not create the client used in functional tests if the BrowserKit component is not available. Try running "composer require symfony/browser-kit".')
ro0NL
approved these changes
Dec 30, 2018
fabpot
approved these changes
Jan 1, 2019
|
Thank you @xabbuh. |
fabpot
added a commit
that referenced
this pull request
Jan 1, 2019
…serKit component (xabbuh) This PR was merged into the 3.4 branch. Discussion ---------- [FrameworkBundle] improve errors in tests missing the BrowserKit component | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #29696 | License | MIT | Doc PR | Commits ------- 7961a29 improve error message when using test client without the BrowserKit component
This was referenced Jan 6, 2019
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.