[Form] Do not ignore the choice groups for caching #29695
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on a different issue I suddenly came over a strange behaviour.
The code above will result in two identical selects:
The reason for this is hash generation in
Symfony\Component\Form\ChoiceList\Factory\CachingFactoryDecorator::createListFromChoices()
— it does not take array structure into account. See the comment and the code below it.The comment says that the same choice list should be returned for the same collection of choices no matter the structure. This is wrong, because
ChoiceListInterface
has a methodgetStructuredValues()
and thus a list instance cannot identified by a hash which does not take structure into account.I propose a simple change that fixes this and allows for similar choice fields with different groupings.
ping @HeahDude