[Security] Prefer clone() over unserialize(serialize()) for user refreshment #29621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
approved these changes
Dec 15, 2018
There was a problem hiding this comment.
Using clone was discussed in #28072 (comment)
but here this php bug gives us no other choices.
ogizanagi
approved these changes
Dec 15, 2018
javiereguiluz
approved these changes
Dec 15, 2018
|
Thank you @chalasr. |
nicolas-grekas
added a commit
that referenced
this pull request
Dec 17, 2018
…r user refreshment (chalasr) This PR was merged into the 3.4 branch. Discussion ---------- [Security] Prefer clone() over unserialize(serialize()) for user refreshment | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #29459 | License | MIT | Doc PR | n/a To not hit the `serialize()` bug reported in the related ticket Commits ------- a8eba80 [Security] Prefer clone over unserialize(serialize()) for user refreshment
This was referenced Jan 6, 2019
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To not hit the
serialize()bug reported in the related ticket