[DI] move RegisterServiceSubscribersPass before DecoratorServicePass #29582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We should prevent regressions on this one, at least with a comment or (ideally) with a new test case for PassConfig |
|
Do you think simply checking the order of the passes returned from |
|
A unit test wouldn't prevent anything IMHO. An integration one might be best! |
|
That's for 3.4 btw! |
|
I switched to 3.4. I'll work on an integration test. |
|
Can I get some direction on the best place for an integration test for this would be? |
|
Wow, looked everywhere but the obvious place - thanks! Integration test added. |
nicolas-grekas
approved these changes
Dec 12, 2018
chalasr
approved these changes
Dec 12, 2018
|
Thank you @kbond. |
nicolas-grekas
added a commit
that referenced
this pull request
Dec 12, 2018
…ervicePass (kbond) This PR was merged into the 3.4 branch. Discussion ---------- [DI] move RegisterServiceSubscribersPass before DecoratorServicePass | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no| Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #29550 | License | MIT | Doc PR | n/a From #29550 (comment): The fact that `RegisterServiceSubscribersPass` runs after `DecoratorServicePass` makes it impossible to decorate a service implementing `ServiceSubscriberInterface` if the decorator does not implement it. Commits ------- c3271d9 [DI] move RegisterServiceSubscribersPass before DecoratorServicePass
This was referenced Jan 6, 2019
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From #29550 (comment): The fact that
RegisterServiceSubscribersPassruns afterDecoratorServicePassmakes it impossible to decorate a service implementingServiceSubscriberInterfaceif the decorator does not implement it.