[Yaml] ensures that the mb_internal_encoding is reset to its initial value #29571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
approved these changes
Dec 11, 2018
nicolas-grekas
changed the title
nicolas-grekas
approved these changes
Dec 11, 2018
|
Thank you @Jola. |
xabbuh
added a commit
that referenced
this pull request
Dec 11, 2018
…ts initial value (Jörn Lang) This PR was merged into the 3.4 branch. Discussion ---------- [Yaml] ensures that the mb_internal_encoding is reset to its initial value | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | When `Symfony\Component\Yaml\Inline::parse` sets the internal encoding to ASCII and the method does an early return or throws an exception, the internal encoding would not be reset. This Patch ensures the reset of the encoding by moving it into a finally block. Commits ------- 56ab129 [Yaml] ensures that the mb_internal_encoding is reset to its initial value
This was referenced Jan 6, 2019
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
Symfony\Component\Yaml\Inline::parsesets the internal encoding to ASCII and the method does an early return or throws an exception, the internal encoding would not be reset.This Patch ensures the reset of the encoding by moving it into a finally block.