[Validator] Added IBAN format for Vatican City State #29531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think patches like these are treated as bugfixes, so should be targetting 3.4 |
fabpot
requested changes
Dec 8, 2018
| @@ -5,6 +5,7 @@ CHANGELOG | |||
| ----- | |||
|
|
|||
| * added options `iban` and `ibanPropertyPath` to Bic constraint | |||
| * added support for Vatican City State IBAN format | |||
There was a problem hiding this comment.
Should be removed when rebased on 3.4 (as this should indeed be considered as a bug fix).
raulfraile
force-pushed
the
feature/iban-vatican-city
branch
from
2374ce9
to
d169bf0
Compare
|
@fabpot thanks for the comments! It's now rebased and targetting |
fabpot
approved these changes
Dec 9, 2018
fabpot
force-pushed
the
feature/iban-vatican-city
branch
from
7826734
to
5f02614
Compare
|
Thank you @raulfraile. |
fabpot
added a commit
that referenced
this pull request
Dec 9, 2018
…fraile) This PR was squashed before being merged into the 3.4 branch (closes #29531). Discussion ---------- [Validator] Added IBAN format for Vatican City State IBAN for Vatican City State was added to [IBAN registry](https://www.swift.com/sites/default/files/resources/iban_registry.pdf) recently. This PR adds support for this new format in the `Iban` validator. | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | License | MIT Commits ------- 5f02614 [Validator] Added IBAN format for Vatican City State
This was referenced Jan 6, 2019
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IBAN for Vatican City State was added to IBAN registry recently. This PR adds support for this new format in the
Ibanvalidator.