Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Form] filter out invalid Intl values #29500

Merged
merged 1 commit into from Dec 8, 2018

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Dec 7, 2018

Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #23679
License MIT
Doc PR

Copy link
Contributor

@HeahDude HeahDude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We miss other choice fields that rely on the same optimized implementation.

@xabbuh xabbuh changed the title [Form] filter out invalid language values [Form] filter out invalid Intl values Dec 8, 2018
@nicolas-grekas
Copy link
Member

Thank you @xabbuh.

@nicolas-grekas nicolas-grekas merged commit a2d6940 into symfony:3.4 Dec 8, 2018
nicolas-grekas added a commit that referenced this pull request Dec 8, 2018
This PR was merged into the 3.4 branch.

Discussion
----------

[Form] filter out invalid Intl values

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #23679
| License       | MIT
| Doc PR        |

Commits
-------

a2d6940 filter out invalid Intl values
@xabbuh xabbuh deleted the issue-23679-3.4 branch December 8, 2018 21:50
This was referenced Jan 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants