Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IntegerType with option 'grouping' set true does not show numbers #29422

Closed
Shoplifter opened this issue Dec 2, 2018 · 1 comment
Closed

IntegerType with option 'grouping' set true does not show numbers #29422

Shoplifter opened this issue Dec 2, 2018 · 1 comment
Labels
Bug Form Status: Reviewed TwigBridge

Comments

@Shoplifter
Copy link
Contributor

Shoplifter commented Dec 2, 2018 •
edited

An IntergerType with the option grouping set to true should be rendered as an <input type="text"> instead of <input type="number"> . I did not test this in all browsers, but Chrome does not show any numbers in that case.
@xabbuh xabbuh mentioned this issue Feb 2, 2019
Merged
@xabbuh
Copy link
Member

xabbuh commented Feb 2, 2019

Thank you for reporting. This issue will be fixed by #30061.

nicolas-grekas added a commit that referenced this issue Feb 8, 2019
@nicolas-grekas
bug #30061 [Form] render integer types with grouping as text input (x…
f331c54 
…abbuh)

This PR was merged into the 3.4 branch.

Discussion
----------

[Form] render integer types with grouping as text input

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #29422
| License       | MIT
| Doc PR        |

Commits
-------

d6a5fde render integer types with grouping as text input
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Form Status: Reviewed TwigBridge
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@nicolas-grekas @Shoplifter @xabbuh @carsonbot