Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Profiler] Grouped deprecations from different packages hide useful info #29392

Closed
mhujer opened this issue Nov 30, 2018 · 2 comments
Closed

Comments

@mhujer
Copy link
Contributor

mhujer commented Nov 30, 2018

Symfony version(s) affected: 4.2.0

Description

When there are deprecations with same message, they are all grouped into one even if they are caused by different packages.

image

I've already fixed two packages (sensiolabs/SensioFrameworkExtraBundle#594 mhujer/JavaScriptErrorHandlerBundle#7), but I would prefer to see all the deprecations at once instead of getting only one. The screenshot shows the third package that appeared only after I fixed the first and then the second.

Possible Solution
Make the text (5 times) clickable and it would unfold all deprecations that are grouped into this row.

@nicolas-grekas
Copy link
Member

nicolas-grekas commented Nov 30, 2018

Hello, the reason why it's grouped is performance: if we collect individual items per deprecation, the memory will explode and performance in dev mode will be horrible. I know because we made it this way to fix such issues.

@mhujer
Copy link
Contributor Author

mhujer commented Nov 30, 2018

@nicolas-grekas That makes sense, thanks for the explanation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants