[Translation] Use XLIFF source rather than resname when there's no target #29308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thewilkybarkid
changed the title
fabpot
approved these changes
Nov 26, 2018
|
Thank you @thewilkybarkid. |
fabpot
added a commit
that referenced
this pull request
Nov 26, 2018
…ere's no target (thewilkybarkid) This PR was merged into the 2.8 branch. Discussion ---------- [Translation] Use XLIFF source rather than resname when there's no target | Q | A | ------------- | --- | Branch? | 2.8 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Relates to #20076 (comment). If there's no `<target>` in an XLIFF but there is a `@resname` then that's used rather than the `<source>`. If I'm using translation keys and my source locale is `en`, then it's a bit redundant to duplicate the `<source>` in the `<target>` in the `en` file (since there is no translation). This isn't changing the behaviour when `<target>` is present but empty. (Caveat: I'm definitely not an expert on XLIFF.) Commits ------- 8633ebb Use XLIFF source rather than resname when there's no target
This was referenced Nov 26, 2018
Merged
Merged
Merged
Closed
Merged
This was referenced Mar 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #20076 (comment). If there's no
<target>in an XLIFF but there is a@resnamethen that's used rather than the<source>.If I'm using translation keys and my source locale is
en, then it's a bit redundant to duplicate the<source>in the<target>in theenfile (since there is no translation).This isn't changing the behaviour when
<target>is present but empty.(Caveat: I'm definitely not an expert on XLIFF.)