[HttpFoundation] Fix trailing space for mime-type with parameters #29271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javiereguiluz
approved these changes
Nov 21, 2018
fabpot
approved these changes
Nov 22, 2018
|
Thank you @SaschaDens. |
fabpot
added a commit
that referenced
this pull request
Nov 22, 2018
…ameters (Sascha Dens) This PR was merged into the 2.8 branch. Discussion ---------- [HttpFoundation] Fix trailing space for mime-type with parameters | Q | A | ------------- | --- | Branch? | 2.8 | Bug fix? | yes | New feature? | no <!-- don't forget to update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #... <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> <!-- Write a short README entry for your feature/bugfix here (replace this comment block.) This will help people understand your PR and can be used as a start of the Doc PR. Additionally: - Bug fixes must be submitted against the lowest branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against the master branch. --> This PR fixes a minor issue that we've discovered by exposing our API towards mobile applications which where sending the header as following `content-type: application/json ;charset=UTF-8`. Request is unable to determine the `getContentType -> getFormat` as **json** due to the whitespace at the end. ```php $request = Request::createFromGlobals(); $request->headers->set('CONTENT_TYPE', 'application/json ;charset=UTF-8'); // Forcing header for test if ($request->getContentType() !== 'json') { // Return 415 (Unsupported Media Type) status code.. } ``` When checking https://tools.ietf.org/html/rfc7231#section-3.1.1.1 it seems that a space is part of the RFC spec. (Where OWS is abbreviated for Optional WhiteSpace) ``` media-type = type "/" subtype *( OWS ";" OWS parameter ) ``` Current the following cases are supported: * application/json; charset=UTF-8 * application/json;charset=UTF-8 The following are failing: * application/json ; charset=UTF-8 * application/json ;charset=UTF-8 Commits ------- f4866bc [HttpFoundation] Fix trailing space for mime-type with parameters
This was referenced Nov 26, 2018
Merged
Merged
Merged
Closed
Merged
This was referenced Mar 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a minor issue that we've discovered by exposing our API towards mobile applications which where sending the header as following
content-type: application/json ;charset=UTF-8. Request is unable to determine thegetContentType -> getFormatas json due to the whitespace at the end.When checking https://tools.ietf.org/html/rfc7231#section-3.1.1.1 it seems that a space is part of the RFC spec. (Where OWS is abbreviated for Optional WhiteSpace)
Current the following cases are supported:
The following are failing: