[Validator] Added the missing constraints instance checks #29223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i think we should target master for this, as a new feature. IMHO a deprecation is not really worth it, so 👍 for throwing. |
|
Well, the code of the validator already expects the right class due to property being used. So these are about providing a good error message in case you mess your project configuration, but it probably already does not work (with a crappier error message) in case of such mess. |
nicolas-grekas
approved these changes
Nov 14, 2018
|
@stof unless someone completely mimics the exepcted api with its own constraint class :} |
stof
approved these changes
Nov 15, 2018
|
Thank you @thomasbisignani. |
nicolas-grekas
added a commit
that referenced
this pull request
Nov 15, 2018
…(thomasbisignani) This PR was merged into the 2.8 branch. Discussion ---------- [Validator] Added the missing constraints instance checks | Q | A | ------------- | --- | Branch? | 2.8 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | This PR adds the constraints instance checks missing to limit the validators use. This behavior is already implemented in all built-in validators, but it was missed in two validators. Commits ------- 0ecaead [Validator] Added the missing constraints instance checks
Merged
This was referenced Nov 26, 2018
Merged
Merged
Merged
This was referenced Mar 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the constraints instance checks missing to limit the validators use.
This behavior is already implemented in all built-in validators, but it was missed in two validators.