[Form] Fixed keeping hash of equal \DateTimeInterface on submit #29185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
HeahDude
commented
Nov 12, 2018
HeahDude
commented
| Q | A |
|---|---|
| Branch? | 2.8 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | ~ |
| License | MIT |
| Doc PR | ~ |
xabbuh
reviewed
Nov 12, 2018
src/Symfony/Component/Form/Tests/Extension/Core/DataMapper/PropertyPathMapperTest.php
Outdated
Show resolved
Hide resolved
HeahDude
force-pushed
the
fix-date-by-reference
branch
from
6adbd7c
to
fafefb1
Compare
xabbuh
approved these changes
Nov 12, 2018
OskarStark
requested changes
Nov 12, 2018
src/Symfony/Component/Form/Extension/Core/DataMapper/PropertyPathMapper.php
Outdated
Show resolved
Hide resolved
HeahDude
force-pushed
the
fix-date-by-reference
branch
from
fafefb1
to
bc2e2cb
Compare
OskarStark
approved these changes
Nov 13, 2018
nicolas-grekas
approved these changes
Nov 13, 2018
|
Thank you @HeahDude. |
nicolas-grekas
added a commit
that referenced
this pull request
Nov 13, 2018
…ubmit (HeahDude) This PR was merged into the 2.8 branch. Discussion ---------- [Form] Fixed keeping hash of equal \DateTimeInterface on submit | Q | A | ------------- | --- | Branch? | 2.8 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | ~ | License | MIT | Doc PR | ~ Commits ------- bc2e2cb [Form] Fixed keeping hash of equal \DateTimeInterface on submit
Merged
This was referenced Nov 26, 2018
Merged
Merged
Merged
This was referenced Mar 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.