[Config] Unset key during normalization #29152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
aiming for 2.8.. i cant imagine ppl rely on UnsetKeyException to be thrown (and handle it themselves) |
nicolas-grekas
approved these changes
Nov 9, 2018
ogizanagi
approved these changes
Nov 10, 2018
fabpot
approved these changes
Nov 12, 2018
|
Thank you @ro0NL. |
fabpot
added a commit
that referenced
this pull request
Nov 12, 2018
This PR was squashed before being merged into the 2.8 branch (closes #29152). Discussion ---------- [Config] Unset key during normalization | Q | A | ------------- | --- | Branch? | 2.8 | Bug fix? | yes-ish | New feature? | yes | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #29142 | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> 2.8 vs. 4.x :) let me know. Commits ------- e1402d4 [Config] Unset key during normalization
Merged
This was referenced Nov 26, 2018
Merged
Merged
Merged
This was referenced Mar 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2.8 vs. 4.x :) let me know.