[DoctrineBridge] catch errors while converting to db values in data collector #28917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Symfony/Bridge/Doctrine/DataCollector/DoctrineDataCollector.php
Outdated
Show resolved
Hide resolved
|
Thanks for the PR. Can you have a look at test failures please? |
|
I’ve initially sumbitted the PR on a wrong base branch and I changed it later, but the build has not restarted, could you please restart it or should I push another commit to rebuild it? |
|
@alekitto you can simply amend your commit and push it again ( |
stof
requested changes
Oct 22, 2018
src/Symfony/Bridge/Doctrine/DataCollector/DoctrineDataCollector.php
Outdated
Show resolved
Hide resolved
alekitto
force-pushed
the
fix-doctrine-data-collector-exception
branch
3 times, most recently
from
e58c5a5
to
0187892
Compare
nicolas-grekas
approved these changes
Nov 24, 2018
src/Symfony/Bridge/Doctrine/DataCollector/DoctrineDataCollector.php
Outdated
Show resolved
Hide resolved
alekitto
force-pushed
the
fix-doctrine-data-collector-exception
branch
from
0187892
to
61c4531
Compare
fabpot
approved these changes
Nov 26, 2018
|
Thank you @alekitto. |
fabpot
added a commit
that referenced
this pull request
Nov 26, 2018
…s in data collector (alekitto) This PR was merged into the 2.8 branch. Discussion ---------- [DoctrineBridge] catch errors while converting to db values in data collector | Q | A | ------------- | --- | Branch? | 2.8 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | License | MIT When the profiler is enabled and collecting doctrine queries data, if a query fails because of `ConversionException` or another error thrown while resolving parameters, the data collector is also throwing the same error. This should fix this case. The tests for this case cannot be executed in 5.4 because Doctrine 2.5 fails with a fatal error in `DateType`. Commits ------- 61c4531 [DoctrineBridge] catch errors while converting to db values in data collector
This was referenced Nov 26, 2018
Merged
Merged
Merged
Closed
Merged
This was referenced Mar 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the profiler is enabled and collecting doctrine queries data, if a query fails because of
ConversionExceptionor another error thrown while resolving parameters, the data collector is also throwing the same error.This should fix this case. The tests for this case cannot be executed in 5.4 because Doctrine 2.5 fails with a fatal error in
DateType.