Listener object (doctrine.orm.entity_listener tagged) have other copy of EntityManager (injected by autowiring) #28869

makm · 2018-10-14T22:09:32Z

Hello. I have a problem with two diffents copy of em

<?php
namespace App\Listener;
use Doctrine\ORM\EntityManagerInterface;

class FirstListener
{
    public function __construct(EntityManagerInterface $entityManager)
    {
        dump('create FirstListener');
        dump($entityManager);
    }
}

<?php
namespace App\Controller;
use Doctrine\ORM\EntityManagerInterface;
use Symfony\Component\HttpFoundation\Response;

class LuckyController
{
    public function number(EntityManagerInterface $entityManager)
    {
        dump('number action invoke');
        dump($entityManager);

        return new Response(
            '<html><body>hello</body></html>'
        );
    }
}

service.yaml:

    App\Listener\FirstListener:
      tags:
      - { name: doctrine.orm.entity_listener }

result:

why ?
for investigation I use:
composer create-project symfony/skeleton blog

The text was updated successfully, but these errors were encountered:

xabbuh · 2018-10-15T08:54:46Z

Can you create a small example application that allows to reproduce your issue?

makm · 2018-10-15T09:43:52Z

very simple. Based on symfony skeleton
https://github.com/makm/em-dupe-bug

dmaicher · 2018-10-15T19:33:58Z

Hmm I think this case should result in a ServiceCircularReferenceException?

If you mark your FirstListener service as lazy: true + require symfony/proxy-manager-bridge it should behave correctly in the meantime.

makm · 2018-10-15T21:09:54Z

Nope. You can see service.yaml (first post) Very simple.
I used xdebug for investigation this problem: symfony create second container

dmaicher · 2018-10-16T06:41:49Z

Nope.

yes currently it does not throw any ServiceCircularReferenceException 😊 But I think it should. Because while building the entity manager service it creates your listener service (which itself needs the entity manager).

makm · 2018-10-17T08:21:24Z

I think there is no 'Circular Reference'. Simple injection for listener as service.
Second: It's problem actual only for Entity Manager.

dmaicher · 2018-10-17T09:27:26Z

I think there is no 'Circular Reference'. Simple injection for listener as service.

For me this is a circular reference.

EntityManager -> EntityListenerResolver -> FirstListener -> EntityManager

Waiting for @nicolas-grekas to have a look and confirm

makm · 2018-10-17T13:18:17Z

In my case: I use service which use EntityManager.
Thats mean - I can't use any services with EntityManager included.

dmaicher · 2018-10-17T13:42:46Z

Thats mean - I can't use any services with EntityManager included.

That's not correct. Your service is a bit special because its tagged as doctrine.orm.entity_listener.

fernetmatt · 2018-11-05T13:38:59Z

I've experienced the same issue using the factory method:

@doctrine.orm.default_entity_manager::getRepository($entityName)

To solve this i had to switch to @doctrine.orm.container_repository_factory::getRepository($EntityManager, $EntityName)

repository.user:
    class: Infrastructure\Persistence\DoctrineORM\Repository\UserRepository
    factory: ["@doctrine.orm.container_repository_factory", getRepository]
    arguments:
      - '@doctrine.orm.default_entity_manager'
      - 'Domain\Entity\User'

Refer to: stackoverflow question

Padam87 · 2019-02-07T19:49:03Z

I have the same issue.

I have 2 services, each getting a different instance of the manager. (spl_object_hash different) Both are using simple constructor injection, autowired, and type hinted as Doctrine\ORM\EntityManagerInterface.

These manager have different units of work, so have different managed entities.

ro0NL · 2019-02-07T20:16:01Z

Is this a duplicate of #30091 also? If so, does #30096 solve it?

Padam87 · 2019-02-07T20:37:07Z

@ro0NL Thank you, this fixed my issue.

The original problem in this issue seem a bit older, so it should be different as @nicolas-grekas pointed out in the PR.

carsonbot · 2020-12-19T13:03:38Z

Hey, thanks for your report!
There has not been a lot of activity here for a while. Is this bug still relevant? Have you managed to find a workaround?

carsonbot · 2020-12-20T13:01:59Z

Hey, thanks for your report!
There has not been a lot of activity here for a while. Is this bug still relevant? Have you managed to find a workaround?

carsonbot · 2021-01-02T13:50:08Z

Hello? This issue is about to be closed if nobody replies.

carsonbot · 2021-01-03T13:05:13Z

Friendly ping? Should this still be open? I will close if I don't hear anything.

makm changed the title ~~Listener object (doctrine.orm.entity_listener tagger) have other copy of EntityManager (injected by autowiring)~~ Listener object (doctrine.orm.entity_listener tagged) have other copy of EntityManager (injected by autowiring) Oct 14, 2018

xabbuh added the Status: Waiting feedback label Oct 15, 2018

xabbuh added DependencyInjection Bug and removed Status: Waiting feedback labels Oct 15, 2018

carsonbot added the Status: Needs Review label Oct 15, 2018

xabbuh added Status: Reviewed and removed Status: Needs Review labels Oct 15, 2018

xabbuh mentioned this issue Nov 5, 2018

Repository made by factory method @doctrine.orm.default_entity_manager::getRepository($entityName) always have different EntityManager doctrine/DoctrineBundle#874

Closed

spackmat mentioned this issue May 24, 2019

[DI] Broken entity manager service #30091

Closed

dmaicher mentioned this issue May 27, 2019

[DoctrineBridge] Trigger a proper error when injection a service containing the entity manager in a doctrine listener #31636

Closed

carsonbot added the Stalled label Dec 19, 2020

xabbuh added the Keep open label Jan 3, 2021

carsonbot removed the Stalled label Jan 16, 2021

SylvainBreton mentioned this issue Sep 9, 2023

Issue after updating symfony dependencyInjection from 6.2 to 6.3 Codeception/module-doctrine#3

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Listener object (doctrine.orm.entity_listener tagged) have other copy of EntityManager (injected by autowiring) #28869

Listener object (doctrine.orm.entity_listener tagged) have other copy of EntityManager (injected by autowiring) #28869

makm commented Oct 14, 2018 •

edited

xabbuh commented Oct 15, 2018

makm commented Oct 15, 2018

dmaicher commented Oct 15, 2018 •

edited

makm commented Oct 15, 2018

dmaicher commented Oct 16, 2018

makm commented Oct 17, 2018

dmaicher commented Oct 17, 2018

makm commented Oct 17, 2018

dmaicher commented Oct 17, 2018

fernetmatt commented Nov 5, 2018 •

edited

Padam87 commented Feb 7, 2019

ro0NL commented Feb 7, 2019

Padam87 commented Feb 7, 2019 •

edited

carsonbot commented Dec 19, 2020

carsonbot commented Dec 20, 2020

carsonbot commented Jan 2, 2021

carsonbot commented Jan 3, 2021

Listener object (doctrine.orm.entity_listener tagged) have other copy of EntityManager (injected by autowiring) #28869

Listener object (doctrine.orm.entity_listener tagged) have other copy of EntityManager (injected by autowiring) #28869

Comments

makm commented Oct 14, 2018 • edited

xabbuh commented Oct 15, 2018

makm commented Oct 15, 2018

dmaicher commented Oct 15, 2018 • edited

makm commented Oct 15, 2018

dmaicher commented Oct 16, 2018

makm commented Oct 17, 2018

dmaicher commented Oct 17, 2018

makm commented Oct 17, 2018

dmaicher commented Oct 17, 2018

fernetmatt commented Nov 5, 2018 • edited

Padam87 commented Feb 7, 2019

ro0NL commented Feb 7, 2019

Padam87 commented Feb 7, 2019 • edited

carsonbot commented Dec 19, 2020

carsonbot commented Dec 20, 2020

carsonbot commented Jan 2, 2021

carsonbot commented Jan 3, 2021

makm commented Oct 14, 2018 •

edited

dmaicher commented Oct 15, 2018 •

edited

fernetmatt commented Nov 5, 2018 •

edited

Padam87 commented Feb 7, 2019 •

edited