[DependencyInjection] Skip empty proxy code #28861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olvlvl
force-pushed
the
olvlvl-phpdumper
branch
from
1a390a4
to
495124d
Compare
|
Looks like there's an issue during the php7.2 build. |
|
Note that while the code may not work correctly when no code is returned, I'm not sure it's legit to return nothing: |
nicolas-grekas
force-pushed
the
olvlvl-phpdumper
branch
from
495124d
to
baf6f8c
Compare
|
Thank you @olvlvl. |
nicolas-grekas
added a commit
that referenced
this pull request
Oct 20, 2018
This PR was merged into the 2.8 branch. Discussion ---------- [DependencyInjection] Skip empty proxy code | Q | A | ------------- | --- | Branch? | 4.1 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #28852 | License | MIT Fix #28852 @nicolas-grekas I'm not sure which branch this should be applied to, please let me know. Commits ------- baf6f8c Skip empty proxy code
This was referenced Nov 3, 2018
Merged
Merged
Merged
This was referenced Mar 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #28852
@nicolas-grekas I'm not sure which branch this should be applied to, please let me know.