[DomCrawler] exclude fields inside "template" tags

[Gorjunov]

Q	A
Branch?	2.8
Bug fix?	yes
New feature?	no
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	#27285
License	MIT
Doc PR

Exclude fields values/files if fields are inside template tag. I think better to exclude values only instead of excluding fields at all (described in ticket #27285)

[jakzal]

I think better to exclude values only instead of excluding fields at all

Could you elaborate on why it's better?

[Gorjunov]

In this case it represents browser's behavior - element is accessible (e.g. by JS), but server will not get values on form submit. (if I understand right that Form:: getValues() is same as form submit in browser)

[nicolas-grekas]

The way this is currently implemented could be understood as a new feature because it's adding a new method. If we can do without the new method, that'd be better to qualify as bugfix.

better to exclude values only instead of excluding fields at all

Shouldn't the $fields be not populated with tags inside template instead?

[stof]

this should indeed be implemented when populating the list of fields, as the form in the DOM does not have this field in this case in a browser. It is not only about the submission skipping the values.

[nicolas-grekas]

(implementation updated to filter fields inside <template> using xpath)

[stof]

Tests should also be updated to test that the Form does not contain the corresponding field at all (has returns false for this field name)

[nicolas-grekas]

@stof test added

[fabpot]

Thank you @Gorjunov.