[RFC] Move annotations from SensioFrameworkExtraBundle to Symfony core

[javiereguiluz]

Q	A
Bug report?	no
Feature request?	yes
BC Break report?	no
RFC?	yes
Symfony version	4.1

SensioFrameworkExtraBundle provides three main features:

• Annotations (@Route(), @Security(), ...)
• Param converters
• PSR-7

This proposal is only about annotations. We started moving some annotations into Symfony core, but we only moved one of them and that's why now we have two @Route annotations:

use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
use Symfony\Component\Routing\Annotation\Route;

So, should we move the rest of annotations to avoid mixing namespaces like this?

use Symfony\Component\Routing\Annotation\Route;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Method;

If you agree with this, should we move each annotation to the related package?

use Symfony\Component\Routing\Annotation\Route;
use Symfony\Component\HttpFoundation\Annotation\Method;
use Symfony\Component\Security\Annotation\Security;
// ...

Or should we put all annotations in the same place to make things simple?

use Symfony\Bridge\Annotation\Route;
use Symfony\Bridge\Annotation\Method;
use Symfony\Bridge\Annotation\Security;
// ...

[nicolas-grekas]

Duplicate of #25103

[javiereguiluz]

Not entirely 😄 The other PR only talks about routing. Here we are talking about all annotations.

[bitgandtter]

I really like the idea of moving annotations and param converters to respective packages or a bridge on core, its a really common and advised practice to use it and core should own it

[curry684]

I'm with @bitgandtter on this one - I've never used routing annotations (I don't like my routing to be spread over 100+ files and their annotations) but I do use ParamConverters wherever possible, and the security annotations on class levels as extra guard. As far as I'm concerned these things are and should be core.

[mateuszsip]

Great idea.
For me annotations should be moved to related components.

[garak]

Why in the core? IMHO a dedicated component (or bridge/bundle) would be better

[bitgandtter]

I agree with @garak but only if this new bridge or bundle is set as a dependency of the FrameworkBundle

[nicolas-grekas]

This is not going to happen: splitting is a significant effort. Unless you want to make it happen...
Either it's in core and this makes the life of the core team easier while making the annotation more widespread, or this stays here IMHO.

[javiereguiluz]

Closing because thanks to the new PHP 8 attributes, we shouldn't focus on PHPdoc-based annotations but on creating new attributes.

[bitgandtter]

It should be the same, annotations, or attributes the main idea of this issue its to not depend on framework extra bundle for these common and high used features. IMO this issue it's still valid, maybe change the name but the scope it's still true

[carsonbot]

Thank you for this suggestion.
There has not been a lot of activity here for a while. Would you still like to see this feature?

[carsonbot]

Just a quick reminder to make a comment on this. If I don't hear anything I'll close this.

[derrabus]

Leave it open, please.

[ro0NL]

Meanwhile sensiolabs/SensioFrameworkExtraBundle#707

at this point maybe just close along with #40571, and take a per-concept approach

[javiereguiluz]

Closing in favor of #44705.

[derrabus]

Oh right, there was already an issue open. 😅