Symfony 3.2 isValid always return false

[dominikzogg]

the following code worked within symfony 2.8 (patch action), after updating to symfony 3.2 i always get into the if statement, even if there are no errors. calling the validator myself, would tell everything is fine.

$form = $this->createForm(UserType::USER_UPDATE, $user);
$form->submit($request->request->all(), false);
if (false === $form->isValid()) {
    ....
}

Do i missed a change, that does not throw an exception, but ends in this strange behavior?

I already refactored the createForm to:

$form = $this->createForm(UserUpdateType::class, $user);

[HeahDude]

Hi @dominikzogg, you should read the 3.2 upgrade file and call:

if ($form->isSubmitted() && false === $form->isValid()) {
    ....
}

Does it solve your issue?

[dominikzogg]

@HeahDude no it does not, i saw within sample, but as you can see within submit() $this->submitted = true; will always be set

[dominikzogg]

$form->submit($request->request->all(), false);

$violationList = $this->get('validator')->validate($user);
if (0 !== $violationList->count()) {...}

doing it this way works perfect, which tells me validation works

[HeahDude]

Hmm, looks weird. Could you please fork symfony standard and add at the minimum of code to reproduce this? Thanks!

[Hanmac]

you shouldn't use submit, which seems to be the problem.

this is how i do it on my systems:

    $form->handleRequest($request);
    if ($form->isSubmitted() && $form->isValid()) {

     }

use this to get the Request:

public function myAction(Request $request) {
}

[dominikzogg]

@Hanmac handleRequest is bad for api, cause the missing second argument which allows to ignore not send values

[dominikzogg]

@HeahDude i can live with duplicate validation for the moment, can't spend the time to strip down this project (big, closed source onces).

[HeahDude]

@dominikzogg can you please try the patch from #20966, to see if this about a transformation failure?

Another possibility is that using false as second argument cause some field(s) to not be submitted while the user pre set data passed at form's creation contains invalid data. See #11493 and #18935.

[dominikzogg]

@HeahDude #20996 is a patch for sf2.7, adapting it does not change anything in my usecase. the problem only happen on POST, PATCH (with second parameter) works.

[xabbuh]

@dominikzogg I am closing here for now as we cannot solve the issue without a reproducable example. However, I will happily reopen once we have such a fork of the Symfony Standard Edition.

[xabbuh]

Can you confirm that the changes proposed in #30265 will fix this issue?