diff --git a/src/Symfony/Component/Form/Form.php b/src/Symfony/Component/Form/Form.php index f3cfc7212ac1..a2d67ec2669d 100644 --- a/src/Symfony/Component/Form/Form.php +++ b/src/Symfony/Component/Form/Form.php @@ -532,11 +532,12 @@ public function submit($submittedData, $clearMissing = true) $submittedData = null; } elseif (is_scalar($submittedData)) { $submittedData = (string) $submittedData; - } elseif ($this->config->getOption('allow_file_upload')) { - // no-op - } elseif ($this->config->getRequestHandler()->isFileUpload($submittedData)) { + } elseif (!$this->config->getOption('allow_file_upload') && $this->config->getRequestHandler()->isFileUpload($submittedData)) { $submittedData = null; $this->transformationFailure = new TransformationFailedException('Submitted data was expected to be text or number, file upload given.'); + } elseif (\is_array($submittedData) && !$this->config->getCompound() && !$this->config->hasOption('multiple')) { + $submittedData = null; + $this->transformationFailure = new TransformationFailedException('Submitted data was expected to be text or number, array given.'); } $dispatcher = $this->config->getEventDispatcher(); diff --git a/src/Symfony/Component/Form/Tests/CompoundFormTest.php b/src/Symfony/Component/Form/Tests/CompoundFormTest.php index 4a6590ded5af..9b5b893dabda 100644 --- a/src/Symfony/Component/Form/Tests/CompoundFormTest.php +++ b/src/Symfony/Component/Form/Tests/CompoundFormTest.php @@ -1036,6 +1036,22 @@ public function testDisabledButtonIsNotSubmitted() $this->assertFalse($submit->isSubmitted()); } + public function testArrayTransformationFailureOnSubmit() + { + $this->form->add($this->getBuilder('foo')->setCompound(false)->getForm()); + $this->form->add($this->getBuilder('bar', null, null, array('multiple' => false))->setCompound(false)->getForm()); + + $this->form->submit(array( + 'foo' => array('foo'), + 'bar' => array('bar'), + )); + + $this->assertNull($this->form->get('foo')->getData()); + $this->assertSame('Submitted data was expected to be text or number, array given.', $this->form->get('foo')->getTransformationFailure()->getMessage()); + + $this->assertSame(array('bar'), $this->form->get('bar')->getData()); + } + public function testFileUpload() { $reqHandler = new HttpFoundationRequestHandler(); diff --git a/src/Symfony/Component/Form/Tests/Extension/Core/Type/UrlTypeTest.php b/src/Symfony/Component/Form/Tests/Extension/Core/Type/UrlTypeTest.php index a72bc985cda7..c80a8b7cfb2e 100644 --- a/src/Symfony/Component/Form/Tests/Extension/Core/Type/UrlTypeTest.php +++ b/src/Symfony/Component/Form/Tests/Extension/Core/Type/UrlTypeTest.php @@ -83,14 +83,6 @@ public function testThrowExceptionIfDefaultProtocolIsInvalid() )); } - public function testSubmitWithNonStringDataDoesNotBreakTheFixUrlProtocolListener() - { - $form = $this->factory->create(static::TESTED_TYPE); - $form->submit(array('domain.com', 'www.domain.com')); - - $this->assertSame(array('domain.com', 'www.domain.com'), $form->getData()); - } - public function testSubmitNullUsesDefaultEmptyData($emptyData = 'empty', $expectedData = 'http://empty') { $form = $this->factory->create(static::TESTED_TYPE, null, array( diff --git a/src/Symfony/Component/Form/Tests/Extension/Validator/Constraints/FormValidatorTest.php b/src/Symfony/Component/Form/Tests/Extension/Validator/Constraints/FormValidatorTest.php index 1d277f6ffcc1..4003ccc01edd 100644 --- a/src/Symfony/Component/Form/Tests/Extension/Validator/Constraints/FormValidatorTest.php +++ b/src/Symfony/Component/Form/Tests/Extension/Validator/Constraints/FormValidatorTest.php @@ -220,7 +220,7 @@ public function testDontValidateConstraintsIfNoValidationGroups() ->getForm(); // Launch transformer - $form->submit(array()); + $form->submit('foo'); $this->expectNoValidate();