From 484668fe563f1d3eb5f2c68d186de915ec587e70 Mon Sep 17 00:00:00 2001 From: Vladimir Reznichenko Date: Tue, 6 Aug 2019 20:02:07 +0200 Subject: [PATCH] SCA: dropped unused mocks, duplicate import and a function alias usage --- .../Tests/Definition/Builder/NumericNodeDefinitionTest.php | 7 +++---- .../ExpressionLanguage/Tests/ExpressionLanguageTest.php | 1 - src/Symfony/Component/Ldap/Tests/LdapTestCase.php | 2 +- .../Security/Guard/Tests/GuardAuthenticatorHandlerTest.php | 7 ------- .../Tests/Firewall/BasicAuthenticationListenerTest.php | 2 -- .../Tests/RememberMe/AbstractRememberMeServicesTest.php | 1 - .../DependencyInjection/TranslationExtractorPassTest.php | 3 --- 7 files changed, 4 insertions(+), 19 deletions(-) diff --git a/src/Symfony/Component/Config/Tests/Definition/Builder/NumericNodeDefinitionTest.php b/src/Symfony/Component/Config/Tests/Definition/Builder/NumericNodeDefinitionTest.php index e60bf407fe6d..aa938bbaa7ed 100644 --- a/src/Symfony/Component/Config/Tests/Definition/Builder/NumericNodeDefinitionTest.php +++ b/src/Symfony/Component/Config/Tests/Definition/Builder/NumericNodeDefinitionTest.php @@ -14,7 +14,6 @@ use PHPUnit\Framework\TestCase; use Symfony\Component\Config\Definition\Builder\FloatNodeDefinition; use Symfony\Component\Config\Definition\Builder\IntegerNodeDefinition; -use Symfony\Component\Config\Definition\Builder\IntegerNodeDefinition as NumericNodeDefinition; class NumericNodeDefinitionTest extends TestCase { @@ -22,7 +21,7 @@ public function testIncoherentMinAssertion() { $this->expectException('InvalidArgumentException'); $this->expectExceptionMessage('You cannot define a min(4) as you already have a max(3)'); - $def = new NumericNodeDefinition('foo'); + $def = new IntegerNodeDefinition('foo'); $def->max(3)->min(4); } @@ -30,7 +29,7 @@ public function testIncoherentMaxAssertion() { $this->expectException('InvalidArgumentException'); $this->expectExceptionMessage('You cannot define a max(2) as you already have a min(3)'); - $node = new NumericNodeDefinition('foo'); + $node = new IntegerNodeDefinition('foo'); $node->min(3)->max(2); } @@ -84,7 +83,7 @@ public function testCannotBeEmptyThrowsAnException() { $this->expectException('Symfony\Component\Config\Definition\Exception\InvalidDefinitionException'); $this->expectExceptionMessage('->cannotBeEmpty() is not applicable to NumericNodeDefinition.'); - $def = new NumericNodeDefinition('foo'); + $def = new IntegerNodeDefinition('foo'); $def->cannotBeEmpty(); } } diff --git a/src/Symfony/Component/ExpressionLanguage/Tests/ExpressionLanguageTest.php b/src/Symfony/Component/ExpressionLanguage/Tests/ExpressionLanguageTest.php index d6e46768bdd6..22d1d1649da1 100644 --- a/src/Symfony/Component/ExpressionLanguage/Tests/ExpressionLanguageTest.php +++ b/src/Symfony/Component/ExpressionLanguage/Tests/ExpressionLanguageTest.php @@ -70,7 +70,6 @@ public function testCachedParseWithDeprecatedParserCacheInterface() { $cacheMock = $this->getMockBuilder('Symfony\Component\ExpressionLanguage\ParserCache\ParserCacheInterface')->getMock(); - $cacheItemMock = $this->getMockBuilder('Psr\Cache\CacheItemInterface')->getMock(); $savedParsedExpression = null; $expressionLanguage = new ExpressionLanguage($cacheMock); diff --git a/src/Symfony/Component/Ldap/Tests/LdapTestCase.php b/src/Symfony/Component/Ldap/Tests/LdapTestCase.php index cc50ecae73dc..9a1424a62e8f 100644 --- a/src/Symfony/Component/Ldap/Tests/LdapTestCase.php +++ b/src/Symfony/Component/Ldap/Tests/LdapTestCase.php @@ -14,7 +14,7 @@ protected function getLdapConfig() $this->markTestSkipped('No server is listening on LDAP_HOST:LDAP_PORT'); } - ldap_close($h); + ldap_unbind($h); return [ 'host' => getenv('LDAP_HOST'), diff --git a/src/Symfony/Component/Security/Guard/Tests/GuardAuthenticatorHandlerTest.php b/src/Symfony/Component/Security/Guard/Tests/GuardAuthenticatorHandlerTest.php index 3bf204ec7f5c..dd41c6980080 100644 --- a/src/Symfony/Component/Security/Guard/Tests/GuardAuthenticatorHandlerTest.php +++ b/src/Symfony/Component/Security/Guard/Tests/GuardAuthenticatorHandlerTest.php @@ -85,13 +85,6 @@ public function testHandleAuthenticationFailure() */ public function testHandleAuthenticationClearsToken($tokenClass, $tokenProviderKey, $actualProviderKey) { - $token = $this->getMockBuilder($tokenClass) - ->disableOriginalConstructor() - ->getMock(); - $token->expects($this->any()) - ->method('getProviderKey') - ->willReturn($tokenProviderKey); - $this->tokenStorage->expects($this->never()) ->method('setToken') ->with(null); diff --git a/src/Symfony/Component/Security/Http/Tests/Firewall/BasicAuthenticationListenerTest.php b/src/Symfony/Component/Security/Http/Tests/Firewall/BasicAuthenticationListenerTest.php index 125d403a7214..08c4e6de37ba 100644 --- a/src/Symfony/Component/Security/Http/Tests/Firewall/BasicAuthenticationListenerTest.php +++ b/src/Symfony/Component/Security/Http/Tests/Firewall/BasicAuthenticationListenerTest.php @@ -74,8 +74,6 @@ public function testHandleWhenAuthenticationFails() 'PHP_AUTH_PW' => 'ThePassword', ]); - $token = $this->getMockBuilder('Symfony\Component\Security\Core\Authentication\Token\TokenInterface')->getMock(); - $tokenStorage = $this->getMockBuilder('Symfony\Component\Security\Core\Authentication\Token\Storage\TokenStorageInterface')->getMock(); $tokenStorage ->expects($this->any()) diff --git a/src/Symfony/Component/Security/Http/Tests/RememberMe/AbstractRememberMeServicesTest.php b/src/Symfony/Component/Security/Http/Tests/RememberMe/AbstractRememberMeServicesTest.php index 75aa0c324bfd..c476e65403c2 100644 --- a/src/Symfony/Component/Security/Http/Tests/RememberMe/AbstractRememberMeServicesTest.php +++ b/src/Symfony/Component/Security/Http/Tests/RememberMe/AbstractRememberMeServicesTest.php @@ -124,7 +124,6 @@ public function testLoginSuccessIsNotProcessedWhenTokenDoesNotContainUserInterfa $service = $this->getService(null, ['name' => 'foo', 'always_remember_me' => true, 'path' => null, 'domain' => null]); $request = new Request(); $response = new Response(); - $account = $this->getMockBuilder('Symfony\Component\Security\Core\User\UserInterface')->getMock(); $token = $this->getMockBuilder('Symfony\Component\Security\Core\Authentication\Token\TokenInterface')->getMock(); $token ->expects($this->once()) diff --git a/src/Symfony/Component/Translation/Tests/DependencyInjection/TranslationExtractorPassTest.php b/src/Symfony/Component/Translation/Tests/DependencyInjection/TranslationExtractorPassTest.php index b5eff6cfcd9f..113536bca89a 100644 --- a/src/Symfony/Component/Translation/Tests/DependencyInjection/TranslationExtractorPassTest.php +++ b/src/Symfony/Component/Translation/Tests/DependencyInjection/TranslationExtractorPassTest.php @@ -50,14 +50,11 @@ public function testProcessMissingAlias() { $this->expectException('Symfony\Component\DependencyInjection\Exception\RuntimeException'); $this->expectExceptionMessage('The alias for the tag "translation.extractor" of service "foo.id" must be set.'); - $definition = $this->getMockBuilder('Symfony\Component\DependencyInjection\Definition')->disableOriginalConstructor()->getMock(); $container = new ContainerBuilder(); $container->register('translation.extractor'); $container->register('foo.id') ->addTag('translation.extractor', []); - $definition->expects($this->never())->method('addMethodCall'); - $translationDumperPass = new TranslationExtractorPass(); $translationDumperPass->process($container); }