This repository has been archived by the owner on Feb 6, 2022. It is now read-only.
Remove not Symfony 5 compliant service argument %kernel.root_dir% #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@l-vo good catch! @nicolas-grekas could you please check if this PR is the right fix for this issue? Thanks! The installation of Symfony 5 is showing the following error at the moment: |
(removed kernel.root_dir doesn't exist anymore in Symfony 5)
l-vo
force-pushed
the
remove_useless_spool.file.abstract_argument
branch
from
21bebc8
to
3653248
Compare
|
@javiereguiluz modified taking in account @nicolas-grekas comment :) |
javiereguiluz
approved these changes
Nov 7, 2019
|
Thank you @l-vo. |
fabpot
added a commit
that referenced
this pull request
Nov 7, 2019
…_dir% (l-vo) This PR was merged into the 3.3-dev branch. Discussion ---------- Remove not Symfony 5 compliant service argument %kernel.root_dir% The service swiftmailer.spool.file.abstract uses %kernel.root_dir% in a path as its first argument. I think this argument is useless since it's replaced in `SwiftMailerExtension`. https://github.com/symfony/swiftmailer-bundle/blob/6b895bc0a5e815d1bf2d444869415a7c752516aa/DependencyInjection/SwiftmailerExtension.php#L262 Can anyone confirm it's not a BC break since a CompilerPass can't be registered and pass (and use this useless value) before `SwiftMailerExtension` code execution ? Commits ------- 3653248 Remove useless swiftmailer.spool.file.abstract argument value
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The service swiftmailer.spool.file.abstract uses %kernel.root_dir% in a path as its first argument. I think this argument is useless since it's replaced in
SwiftMailerExtension.swiftmailer-bundle/DependencyInjection/SwiftmailerExtension.php
Line 262 in 6b895bc
Can anyone confirm it's not a BC break since a CompilerPass can't be registered and pass (and use this useless value) before
SwiftMailerExtensioncode execution ?