This repository has been archived by the owner on Feb 6, 2022. It is now read-only.
Twig 2.10 Deprecation Update to swiftmailer.html.twig #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change addresses the following Twig deprecation: Adding an if condition on a for tag is deprecated in Twig 2.10. Use a filter filter or an "if" condition inside the "for" body instead (if your condition depends on a variable updated inside the loop) This solution uses the "filter" filter to maintain the single-tag "for" previously in place over adding a separate "if" tag. Reference: https://twig.symfony.com/doc/2.x/deprecated.html
KrisCarr
changed the title
KrisCarr
added a commit
to KrisCarr/swiftmailer-bundle
that referenced
this pull request
May 10, 2019
…ilter This change addresses the following Twig deprecation: Adding an if condition on a for tag is deprecated in Twig 2.10. Use a filter filter or an "if" condition inside the "for" body instead (if your condition depends on a variable updated inside the loop). https://twig.symfony.com/doc/2.x/deprecated.html This solution uses a separate "if" block instead of a "filter" which requires Twig 1.41 or higher. (https://twig.symfony.com/doc/2.x/filters/filter.html) A solution that does use "filter" can be found at symfony#282
KrisCarr
added a commit
to KrisCarr/swiftmailer-bundle
that referenced
this pull request
May 10, 2019
This change addresses the following Twig deprecation: Adding an if condition on a for tag is deprecated in Twig 2.10. Use a filter filter or an "if" condition inside the "for" body instead (if your condition depends on a variable updated inside the loop). https://twig.symfony.com/doc/2.x/deprecated.html This solution uses a separate "if" block instead of a "filter" which requires Twig 1.41 or higher. (https://twig.symfony.com/doc/2.x/filters/filter.html) A solution that does use "filter" can be found at symfony#282
|
Thank you @KrisCarr. |
fabpot
added a commit
that referenced
this pull request
May 11, 2019
…arr) This PR was merged into the 3.2-dev branch. Discussion ---------- Twig 2.10 Deprecation Update to swiftmailer.html.twig This change addresses the following Twig deprecation: > Adding an if condition on a for tag is deprecated in Twig 2.10. Use a filter filter or an "if" condition inside the "for" body instead (if your condition depends on a variable updated inside the loop). https://twig.symfony.com/doc/2.x/deprecated.html This solution uses the "filter" filter to maintain the single-tag "for" previously in place over adding a separate "if" tag. This requires Twig 1.41 or higher. (https://twig.symfony.com/doc/2.x/filters/filter.html) A solution that does not use "filter" can be found at #284 Commits ------- ad98ef1 Update swiftmailer.html.twig
fabpot
added a commit
that referenced
this pull request
Jan 25, 2021
…2.0 (andkovt) This PR was merged into the main branch. Discussion ---------- Fixing composer conflict section to allow twig/twig >=1.41,<2.0 Constraint defined in composer.json conflict section prevents from using twig versions from 1.41 up to 2.0. Looking at the reason why this constraint was added - #282 - 2e5f0d6 it seems that this is an error and twig/twig >=1.41,<2.0 should be supported by this package since twig 1.41+ supports "filter" https://twig.symfony.com/doc/1.x/filters/filter.html Commits ------- 3491397 Fixing composer conflict section to allow twig/twig >=1.41,<2.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change addresses the following Twig deprecation:
This solution uses the "filter" filter to maintain the single-tag "for" previously in place over adding a separate "if" tag. This requires Twig 1.41 or higher. (https://twig.symfony.com/doc/2.x/filters/filter.html)
A solution that does not use "filter" can be found at #284