This repository has been archived by the owner on Feb 6, 2022. It is now read-only.
Throwing Exception for bad URL formats #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @maitre-hibou. |
fabpot
added a commit
that referenced
this pull request
Apr 18, 2019
This PR was squashed before being merged into the 3.2-dev branch (closes #273). Discussion ---------- Throwing Exception for bad URL formats Hello there, **Description** : When supplying a wrong URL format in the `MAILER_URL` environment variable, Swiftmailer Transport component is initialized with bundle default configuration values. Therefore, when trying to send emails, a "silent" error is triggered with the following message : `Exception occurred while flushing email queue: Connection could not be established with host localhost [Address not available #99]`. **Changes made** : This PR now throws an `InvalidArgumentException` if supplied URL is not parseable by PHP's `parse_url` method. Commits ------- c31bc23 Throwing Exception for bad URL formats
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello there,
Description : When supplying a wrong URL format in the
MAILER_URLenvironment variable, Swiftmailer Transport component is initialized with bundle default configuration values.Therefore, when trying to send emails, a "silent" error is triggered with the following message :
Exception occurred while flushing email queue: Connection could not be established with host localhost [Address not available #99].Changes made : This PR now throws an
InvalidArgumentExceptionif supplied URL is not parseable by PHP'sparse_urlmethod.