Skip to content
This repository has been archived by the owner on Feb 6, 2022. It is now read-only.

decode username and password from url #263

Merged
merged 1 commit into from Apr 18, 2019
Merged

Conversation

eeemarv
Copy link
Contributor

@eeemarv eeemarv commented Oct 31, 2018

@naderman
Copy link

@eeemarv stof suggested you do this instead: #270 (comment)

@eeemarv
Copy link
Contributor Author

eeemarv commented Apr 18, 2019

Now using rawurldecode() and including host.

@naderman
Copy link

In summary, this PR fixes #234 #270 and #276

@eeemarv
Copy link
Contributor Author

eeemarv commented Apr 18, 2019

Sorry, I just noticed the naming of the commit is wrong. It should be "rawurlDECode() host, username and password" instead of "rawurlencode". In the code the right function is used though.

@eeemarv
Copy link
Contributor Author

eeemarv commented Apr 18, 2019

Note the query part is already urldecoded as the parse_str() function does this.

@naderman
Copy link

naderman commented Apr 18, 2019

@fabpot I know you're focused on Mailer these days, but mind merging this? I think it's a somewhat common problem to run into on a current Symfony4 project, e.g. when following the docs on sending email with GMail https://symfony.com/doc/current/email.html#using-gmail-to-send-emails This will not currently work if a password contains non-ascii characters, even if they get encoded.

@fabpot
Copy link
Member

fabpot commented Apr 18, 2019

Thank you @eeemarv.

@fabpot fabpot merged commit d170a10 into symfony:master Apr 18, 2019
fabpot added a commit that referenced this pull request Apr 18, 2019
This PR was squashed before being merged into the 3.2-dev branch (closes #263).

Discussion
----------

decode username and password from url

#234

Commits
-------

d170a10 decode username and password from url
@naderman naderman mentioned this pull request Apr 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants