-
-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keep existing constraints in package.json #965
Keep existing constraints in package.json #965
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😍
I've just made a small suggestion so that the test case will cover BOTH situations (when a constraint should not be updated but also when it SHOULD be updated). I've tested things locally, including these test changes. It's all working awesomely!
Thanks @smnandre!
Thank you both for your review and your suggestions 😃 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is ready to go - excellent work - it seems to work great when I played with the test locally!
The base branch was changed.
b4bbd2c
to
ae95fe1
Compare
Thank you @smnandre. |
When a dependency constraint is already set in the package.json, the PackageSynchroniser replaces it with even if the constraint is valid.
This PR changes this behaviour and let the constraint untouched if it matches the one provided by the PHP package.
Related issues: