Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop remaining direct containers/common usage #2916

Closed
dtrudg opened this issue May 14, 2024 · 0 comments · Fixed by #2917
Closed

Drop remaining direct containers/common usage #2916

dtrudg opened this issue May 14, 2024 · 0 comments · Fixed by #2917
Assignees
@dtrudg
Milestone
SingularityCE 4.2.0

Comments

@dtrudg
Copy link
Member

dtrudg commented May 14, 2024

Type of issue

technical debt

Description of issue

We currently still directly import containers/common for a small number of things:

  • string constant for oci attach keyboard shortcut
  • default seccomp profile

We can replace these to drop the dependency.
@dtrudg dtrudg added this to the SingularityCE 4.2.0 milestone May 14, 2024
@dtrudg dtrudg self-assigned this May 14, 2024
@dtrudg dtrudg mentioned this issue May 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dtrudg dtrudg

Labels
None yet
Projects
None yet
Milestone
SingularityCE 4.2.0
Development

Successfully merging a pull request may close this issue.

deps: Drop containers/common dtrudg/singularity
1 participant
@dtrudg