Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experimental Mount Command #195

Merged
merged 4 commits into from Apr 5, 2022
Merged

Experimental Mount Command #195

merged 4 commits into from Apr 5, 2022

Conversation

tri-adam
Copy link
Member

@tri-adam tri-adam commented Mar 28, 2022

Add experimental mount command, which attempts to mount the primary system partition of a SIF image. At the moment, only SquashFS partitions are supported via squashfuse. Add OptWithExperimental to enable/disable hidden, experimental commands in siftool.

Closes #191

@tri-adam tri-adam self-assigned this Mar 28, 2022
@codecov-commenter
Copy link

codecov-commenter commented Apr 4, 2022

Codecov Report

Merging #195 (389f08f) into master (d7a38b5) will decrease coverage by 0.18%.
The diff coverage is 58.06%.

@@            Coverage Diff             @@
##           master     #195      +/-   ##
==========================================
- Coverage   76.46%   76.28%   -0.19%     
==========================================
  Files          28       30       +2     
  Lines        2503     2534      +31     
==========================================
+ Hits         1914     1933      +19     
- Misses        450      461      +11     
- Partials      139      140       +1     
Impacted Files Coverage Δ
internal/app/siftool/mount.go 0.00% <0.00%> (ø)
internal/app/siftool/app.go 65.21% <16.66%> (-17.14%) ⬇️
pkg/siftool/mount.go 72.72% <72.72%> (ø)
pkg/siftool/siftool.go 92.30% <100.00%> (+5.64%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7a38b5...389f08f. Read the comment docs.

@tri-adam tri-adam marked this pull request as ready for review April 4, 2022 18:35
Copy link
Member

@dtrudg dtrudg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Confirmed working on Fedora 35

@tri-adam tri-adam merged commit 6346972 into sylabs:master Apr 5, 2022
@tri-adam tri-adam deleted the mount branch April 5, 2022 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unprivileged SquashFS Mount
3 participants