New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Image Compaction Logic #193

Open

tri-adam opened this issue Mar 28, 2022 · 0 comments

Labels

Member

tri-adam commented Mar 28, 2022

When OptDeleteCompact is passed to (*FileImage).DeleteObject, an error is thrown if the object being deleted is not last in the SIF image:

sif/pkg/sif/create.go

Line 502 in 28ad31b

    
           var errCompactNotImplemented = errors.New("compact not implemented for non-last object")

This makes compaction difficult to use, since the caller needs to be aware of this limitation, and work around it.

We should extend compaction to work regardless of the position of the object being deleted.

tri-adam added the enhancement label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment