From 1b339d764b127a9307c32cabc67f01d0297de2c7 Mon Sep 17 00:00:00 2001 From: Mike Frisch Date: Tue, 2 Aug 2022 14:58:04 -0400 Subject: [PATCH 1/4] fix(ci): update to node 18 --- .circleci/config.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index d52e413..7fa0ec8 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -6,7 +6,7 @@ orbs: executors: node: docker: - - image: node:17-slim + - image: node:18-slim golangci-lint: docker: - image: golangci/golangci-lint:v1.47 From 5b96237e039b539817f9cc6b205b27a9e23985ff Mon Sep 17 00:00:00 2001 From: Mike Frisch Date: Tue, 2 Aug 2022 14:58:27 -0400 Subject: [PATCH 2/4] fix(ci): use supported Go versions 1.18 and 1.19 --- .circleci/config.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 7fa0ec8..cba368d 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -12,10 +12,10 @@ executors: - image: golangci/golangci-lint:v1.47 golang-previous: docker: - - image: golang:1.17 + - image: golang:1.18 golang-latest: docker: - - image: golang:1.18 + - image: golang:1.19 jobs: lint-markdown: From 996826888262997857f4baa7801d1d05c5668abf Mon Sep 17 00:00:00 2001 From: Mike Frisch Date: Wed, 3 Aug 2022 09:05:11 -0400 Subject: [PATCH 3/4] fix: update go.mod --- go.mod | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/go.mod b/go.mod index 5508981..a655e79 100644 --- a/go.mod +++ b/go.mod @@ -1,3 +1,3 @@ module github.com/sylabs/json-resp -go 1.17 +go 1.18 From 923bba99793f86a1fe938150797800593563485b Mon Sep 17 00:00:00 2001 From: Adam Hughes <9903835+tri-adam@users.noreply.github.com> Date: Mon, 29 Aug 2022 21:13:23 +0000 Subject: [PATCH 4/4] chore: bump golangci-lint to v1.49 Disable deprecated deadcode, structcheck and varcheck linters. Add interfacebloat and reassign linters. Sort list of enabled linters in ascending order. --- .circleci/config.yml | 2 +- .golangci.yml | 10 ++++------ 2 files changed, 5 insertions(+), 7 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index cba368d..c9b1c91 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -9,7 +9,7 @@ executors: - image: node:18-slim golangci-lint: docker: - - image: golangci/golangci-lint:v1.47 + - image: golangci/golangci-lint:v1.49 golang-previous: docker: - image: golang:1.18 diff --git a/.golangci.yml b/.golangci.yml index c22dd23..e9a40ec 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -5,17 +5,16 @@ linters: - bodyclose - containedctx - contextcheck - - deadcode - decorder - depguard - dogsled - dupl - errcheck + - errchkjson - funlen - gochecknoinits - - gocognit - - errchkjson - gochecknoinits + - gocognit - goconst - gocritic - gocyclo @@ -28,21 +27,20 @@ linters: - govet - grouper - ineffassign + - interfacebloat - ireturn - maintidx - misspell - nakedret - nilnil - prealloc + - reassign - revive - - rowserrcheck - staticcheck - - structcheck - stylecheck - tenv - typecheck - unconvert - unparam - unused - - varcheck - whitespace