Skip to content
This repository has been archived by the owner on Mar 31, 2024. It is now read-only.

Add PowerShell completion #184

Merged
merged 4 commits into from Jul 4, 2021
Merged

Add PowerShell completion #184

merged 4 commits into from Jul 4, 2021

Conversation

rashil2000
Copy link
Contributor

@rashil2000 rashil2000 commented Jul 2, 2021

Closes #183

Copy link
Owner

@swsnr swsnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase onto main and update CHANGELOG.md, and please check whether the package script correctly includes the new completion file in release tarballs.

@rashil2000
Copy link
Contributor Author

...please check whether the package script correctly includes the new completion file in release tarballs.

I'm a bit of a beginner here, could you tell me how to do this? Should I simply call the scripts/package shell script?

@swsnr
Copy link
Owner

swsnr commented Jul 2, 2021

@rashil2000 Exactly; you need to make a release build with cargo build --release first. But as far as I'm concerned you can also just check the code of that script to see what it includes; if the file is missing I guess you'll notice on the next release 😉

@rashil2000
Copy link
Contributor Author

rashil2000 commented Jul 3, 2021

I did that (after setting env variable OUT_DIR=out), but it returns some errors. But when I search for the completion file, I can see it in the target directory:

image

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
@swsnr
Copy link
Owner

swsnr commented Jul 4, 2021

@rashil2000 The package script takes arguments; take a look at how it's called in the Github release workflow.

@rashil2000
Copy link
Contributor Author

Okay, I was able to generate the archive mdcat-0.22.4-x86_64-pc-windows-msvc.zip, and it does contain the PowerShell completion file in the 'completions' folder.

@swsnr swsnr merged commit 3d483f1 into swsnr:main Jul 4, 2021
@rashil2000 rashil2000 deleted the pwsh-complete branch July 4, 2021 13:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants